Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSI Hostpath driver as addon to minikube #8815

Closed
11janci opened this issue Jul 23, 2020 · 1 comment · Fixed by #8461
Closed

Add CSI Hostpath driver as addon to minikube #8815

11janci opened this issue Jul 23, 2020 · 1 comment · Fixed by #8461
Labels
area/addons help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@11janci
Copy link
Contributor

11janci commented Jul 23, 2020

I am currently working on enabling Volume Snapshots in minikube: #8343. Enabling the snapshots is however useless without a CSI based storage provider, which the user would have to configure manually. Adding the CSI hostpath driver as an addon would not only make the volume snapshots ready for use, but provide a complete CSI based storage solution to minikube.

This change would bring all the required yaml files from the driver to minikube. These files are dependent on kubernetes version, thus an upgrade of kubernetes in minikube could break it. However with a proper integration test this should be detected immediately and the yaml files upgraded accordingly.

If approved, I will rework my PR (#8461) and once done it would close both this issue as well as #8343.

kind/feature
@sharifelgamal sharifelgamal added area/addons kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jul 27, 2020
@11janci 11janci mentioned this issue Jul 29, 2020
Merged
@priyawadhwa
Copy link

This feature is currently in progress, thanks @11janci !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/addons help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CSI Hostpath Driver & VolumeSnapshots addons 11janci/minikube
3 participants
@priyawadhwa @sharifelgamal @11janci