Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update go version to be 1.15 in go mod #9264

Closed
medyagh opened this issue Sep 16, 2020 · 4 comments · Fixed by #9280 or #9464
Closed

update go version to be 1.15 in go mod #9264

medyagh opened this issue Sep 16, 2020 · 4 comments · Fixed by #9280 or #9464
Assignees
@prezha
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/process Process oriented issues, like setting up CI priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@medyagh
Copy link
Member

medyagh commented Sep 16, 2020

to match
https://github.com/kubernetes/kubernetes/blob/09b3f6dbb3224f32d28c81f330f303ac16ee2eae/go.mod#L9
@medyagh medyagh added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/process Process oriented issues, like setting up CI priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Sep 16, 2020
@afbjorklund
Copy link
Collaborator

afbjorklund commented Sep 17, 2020 •
edited
Loading

The master image is k8s.gcr.io/build-image/kube-cross:v1.15.2-1

kubernetes/kubernetes@a4a98f4

So that is the minor version that we should be using (but 1.15 for go.mod)

GO_VERSION ?= 1.15.2

Don't forget to update .travis.yml and .github/workflows/*.yml !

The new ISO has go1.13, which is a problem for podman/cri-o.

Other system programs are fine with that go compiler version...

Mostly since they don't import kubernetes, which is latest/greatest

@ravindrabhargava
Copy link

I would like to understand it more and also like to work on it Thanks

@prezha
Copy link
Contributor

prezha commented Sep 20, 2020

/assign

@prezha prezha mentioned this issue Sep 20, 2020
Merged
@afbjorklund
Copy link
Collaborator

afbjorklund commented Sep 27, 2020 •
edited
Loading

The new ISO has go1.13, which is a problem for podman/cri-o.

Other system programs are fine with that go compiler version...

Mostly since they don't import kubernetes, which is latest/greatest

This comment was regarding the go compiler version in Buildroot

Also know that it is not a problem until CRI-O 1.19 (1.18.3 is fine)

This was referenced Oct 11, 2020
Closed
Merged
Closed
@prezha prezha mentioned this issue Oct 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@prezha prezha

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/process Process oriented issues, like setting up CI priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
No milestone
4 participants
@medyagh @prezha @afbjorklund @ravindrabhargava