Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proto files being copied redux #141

Closed
jmhodges opened this issue Jan 3, 2019 · 4 comments
Closed

proto files being copied redux #141

jmhodges opened this issue Jan 3, 2019 · 4 comments

Comments

@jmhodges
Copy link

jmhodges commented Jan 3, 2019

This is the same bug as #49 but now the .proto files are in k8s.io/api. Specifically, files like https://github.com/kubernetes/api/blob/173ce66c1e39d1d0f56e0b3347ff2988068aecd0/authentication/v1/generated.proto

I'm having to fork k8s.io/api again to fix this.
@sttts
Copy link
Contributor

sttts commented Jan 3, 2019

Isn't this intentional? Having proto definitions in an api repo sounds natural.

@jmhodges
Copy link
Author

jmhodges commented Jan 3, 2019

Did you read the ticket, though? It breaks things for bazel users. It was fixed before, so it seems like there’s precedent. The protos can still live elsewhere

@jmhodges
Copy link
Author

jmhodges commented Jan 4, 2019

Ah, that was about BUILD files. I should have re-read, myself! Hm. I'm going to talk to the bazel folks to go a bit deeper in. Will close or update here within a day

@jmhodges
Copy link
Author

jmhodges commented Jan 5, 2019

Okay this is bazel-contrib/bazel-gazelle#209 which is dependent on bazelbuild/bazel#3867. Thanks for your patience! I'll close this now

@jmhodges jmhodges closed this as completed Jan 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jmhodges @sttts