Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable outlier detection #276

Open
BenTheElder opened this issue Feb 14, 2024 · 5 comments
Open

enable outlier detection #276

BenTheElder opened this issue Feb 14, 2024 · 5 comments
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.

Comments

@BenTheElder
Copy link
Member

We should enable https://cloud.google.com/load-balancing/docs/https/setting-up-global-traffic-mgmt#configure_outlier_detection

https://github.com/kubernetes/k8s.io/tree/main/infra/gcp/terraform/modules/oci-proxy

I think last time I looked into this I got hung up on migrating to current terraform / modules versions in k8s.io and then got interrupted with other priorities, but it might be possible to do without updating those first.

xref: #274 (comment), previously #234

@upodroid
Copy link
Member

Might not work as we are using Serverless NEGs that don't have health checks.

@BenTheElder
Copy link
Member Author

Might not work as we are using Serverless NEGs that don't have health checks.

Outlier detection doesn't rely on (active) healthchecks, it's basically acting on observed response codes to normal requests.

It is available for serverless NEGs for a while now, with some limitations (I forget which but IIRC one of the config options wasn't applicable).

@BenTheElder
Copy link
Member Author

It might not have solved this particular outage though, if nothing else since it's an LB behavior and LBs are impacted in some way (haven't had a chance to look further for now).

@BenTheElder BenTheElder added the sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra. label Feb 14, 2024
@BenTheElder BenTheElder added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 27, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 25, 2024
@BenTheElder
Copy link
Member Author

/remove-lifecycle stale
/lifecycle frozen

We should still probably do this, it's just hard to prioritize versus getting the rest of the infra migrated into the community, we're rarely having outages as-is and it's not 100% clear if this would solve the problem(s) (needs more investigating, just haven't really had time and nobody else seems to have looked yet).

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/k8s-infra Categorizes an issue or PR as relevant to SIG K8s Infra.
Projects
None yet
Development

No branches or pull requests

4 participants