Skip to content

Commit 56bb98e

Browse files
committed
anago: Skip image pushes in --nomock mode
Signed-off-by: Stephen Augustus <saugustus@vmware.com>
1 parent a0a6ebc commit 56bb98e

File tree

1 file changed

+15
-3
lines changed

1 file changed

+15
-3
lines changed

anago

Lines changed: 15 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -280,7 +280,8 @@ ensure_registry_acls () {
280280
# When we are no-mock mode we need to perform an image promotion, so it's
281281
# unnecessary to check for write access to the production container registry.
282282
if ((FLAGS_nomock)); then
283-
logecho "Skipping registry ACL check on $GCRIO_PATH_PROD in no-mock mode"
283+
logecho -n "Skipping container registry ACL check on $GCRIO_PATH_PROD in no-mock mode: "
284+
logecho $OK
284285
return 0
285286
else
286287
artifact_namespace="${r/gcr.io\//}"
@@ -1445,8 +1446,19 @@ push_all_artifacts () {
14451446
gs://$RELEASE_BUCKET/$BUCKET_TYPE/$version || return 1
14461447
fi
14471448

1448-
common::runstep release::docker::release \
1449-
$KUBE_DOCKER_REGISTRY $version $BUILD_OUTPUT-$version || return 1
1449+
# When we are no-mock mode we need to perform an image promotion, so
1450+
# instead of pushing to the production container registry, we validate
1451+
# that the manifest is populated on the remote registry.
1452+
1453+
# TODO(vdf): Add image manifest validation logic
1454+
# Maybe consider adding this to release::docker::release
1455+
# and renaming that function.
1456+
if ((FLAGS_nomock)); then
1457+
logecho "Validating image manifests (# TODO(vdf): currently a no-op)..." || return 1
1458+
else
1459+
common::runstep release::docker::release \
1460+
$KUBE_DOCKER_REGISTRY $version $BUILD_OUTPUT-$version || return 1
1461+
fi
14501462

14511463
common::runstep release::gcs::publish_version \
14521464
$BUCKET_TYPE $version $BUILD_OUTPUT-$version $RELEASE_BUCKET || return 1

0 commit comments

Comments
 (0)