Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete draft release question is misleading #273

Closed
mwielgus opened this issue Mar 7, 2017 · 5 comments
Closed

Delete draft release question is misleading #273

mwielgus opened this issue Mar 7, 2017 · 5 comments
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.

Comments

@mwielgus
Copy link

mwielgus commented Mar 7, 2017 •
edited
Loading

It is not obvious how to answer this the below question.
If I say "Y" will the tool recreate the release as "final" or not?

────────────────────────────────────────────────────────────────────────────────
UPDATE GITHUB RELEASES PAGE
────────────────────────────────────────────────────────────────────────────────

Posting the v1.5.4 release on github...
Uploading binary to github: OK

ATTENTION: A draft release of v1.5.4 was created at
https://github.com/kubernetes/kubernetes/releases.

Delete draft release (id #5669951) now? (Y/n):

cc: @ixdy @david-mcmahon
@ixdy
Copy link
Member

ixdy commented Mar 7, 2017

was this a mock or nomock run?

@mwielgus
Copy link
Author

mwielgus commented Mar 7, 2017

Regular run kubernetes/test-infra#1795

@mwielgus
Copy link
Author

mwielgus commented Mar 7, 2017 •
edited
Loading

The final release was NOT created after answering Y.

@mwielgus
Copy link
Author

mwielgus commented Mar 7, 2017

Ok. My fault - i missed that it was a mock run.

@ixdy
Copy link
Member

ixdy commented Mar 8, 2017

closing this in favor of #274.

@ixdy ixdy closed this as completed Mar 8, 2017
@justaugustus justaugustus added sig/release Categorizes an issue or PR as relevant to SIG Release. area/release-eng Issues or PRs related to the Release Engineering subproject labels Dec 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@justaugustus @ixdy @mwielgus