Skip to content

Commit 80f5e0b

Browse files
authored
Merge pull request #14768 from BenTheElder/binfmt_fire
don't touch binfmt_misc in prow
2 parents 762b3b1 + 104a0b1 commit 80f5e0b

File tree

1 file changed

+0
-19
lines changed

1 file changed

+0
-19
lines changed

images/bootstrap/runner.sh

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -24,23 +24,6 @@ if [[ "${BAZEL_REMOTE_CACHE_ENABLED}" == "true" ]]; then
2424
fi
2525

2626

27-
# used by cleanup_dind to ensure binfmt_misc entries are not persisted
28-
# TODO: consider moving *all* cleanup into a more robust program
29-
cleanup_binfmt_misc() {
30-
# make sure the vfs is mounted
31-
# TODO: if this logic is moved out and made more general
32-
# we need to check that the host actually has binfmt_misc support first.
33-
if [ ! -f /proc/sys/fs/binfmt_misc/status ]; then
34-
mount binfmt_misc -t binfmt_misc /proc/sys/fs/binfmt_misc
35-
fi
36-
# https://www.kernel.org/doc/html/v4.13/admin-guide/binfmt-misc.html
37-
# You can remove one entry or all entries by echoing -1
38-
# to /proc/.../the_name or /proc/sys/fs/binfmt_misc/status.
39-
echo -1 >/proc/sys/fs/binfmt_misc/status
40-
# list entries
41-
ls -al /proc/sys/fs/binfmt_misc
42-
}
43-
4427
# runs custom docker data root cleanup binary and debugs remaining resources
4528
cleanup_dind() {
4629
barnacle || true
@@ -50,8 +33,6 @@ cleanup_dind() {
5033
docker volume ls || true
5134
# cleanup binfmt_misc
5235
echo "Cleaning up binfmt_misc ..."
53-
# note: we run this in a subshell so we can trace it for now
54-
(set -x; cleanup_binfmt_misc || true)
5536
}
5637

5738
# optionally enable ipv6 docker

0 commit comments

Comments
 (0)