Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect information regarding VolumeSnapshot API in v1.24 upcoming removals article #34143

Closed
xing-yang opened this issue Jun 6, 2022 · 8 comments · Fixed by #34173
Closed
Assignees
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/needs-information Indicates an issue needs more information in order to work on it.

Comments

@xing-yang
Copy link
Contributor

This is a Bug Report

Problem:
Information regarding volume snapshot API in the following blog is not accurate.
https://kubernetes.io/blog/2022/04/07/upcoming-changes-in-kubernetes-1-24/#api-removals-deprecations-and-other-changes-for-kubernetes-1-24
Volume snapshot API moved to GA in 1.20, so volume snapshot v1beta1 was deprecated in 1.20.

Proposed Solution:
Information regarding volume snapshot API in this blog is correct:
https://kubernetes.io/blog/2022/05/03/kubernetes-1-24-release-announcement/#csi-snapshot

Please update the API Removals Deprecations blog accordingly.

Page to Update:
https://kubernetes.io/...

@xing-yang xing-yang added the kind/bug Categorizes issue or PR as related to a bug. label Jun 6, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jun 6, 2022
@k8s-ci-robot
Copy link
Contributor

@xing-yang: This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sftim
Copy link
Contributor

sftim commented Jun 6, 2022

/retitle Incorrect information regarding VolumeSnapshot API in v1.24 upcoming removals article
/area blog
/language en

What is the correct statement about the fate of the v1beta1 API for VolumeSnapshot @xing-yang? When did (or will) that API version transition from deprecated to unsupported?

@k8s-ci-robot k8s-ci-robot changed the title Information regarding volume snapshot API needs to be fixed Incorrect information regarding VolumeSnapshot API in v1.24 upcoming removals article Jun 6, 2022
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language labels Jun 6, 2022
@sftim
Copy link
Contributor

sftim commented Jun 6, 2022

I suspect the fix is to edit:

VolumeSnapshot v1beta1 was deprecated in v1.21 and is now unsupported

to:

VolumeSnapshot v1beta1 was deprecated in v1.20 and will become unsupported once Kubernetes v1.24 is released.

Does that sound right?

/triage needs-information

@k8s-ci-robot k8s-ci-robot added the triage/needs-information Indicates an issue needs more information in order to work on it. label Jun 6, 2022
@humblec
Copy link
Contributor

humblec commented Jun 6, 2022

@sftim
Change 1:

which provides standardized APIs design (CRDs) and adds PV snapshot/restore support for CSI volume drivers, entered beta in v1.20

Above has to be : [diff: beta to GA]

which provides standardized APIs design (CRDs) and adds PV snapshot/restore support for CSI volume drivers, entered GA in v1.20.

Change 2:

VolumeSnapshot v1beta1 was deprecated in v1.21 and is now unsupported.

Above has to be: [diff v1.21 to v1.20]

VolumeSnapshot v1beta1 was deprecated in v1.20 ..

@xing-yang
Copy link
Contributor Author

@sftim The following is correct:

VolumeSnapshot v1beta1 CRD has been removed. Volume snapshot and restore functionality for Kubernetes and the Container Storage Interface (CSI), which provides standardized APIs design (CRDs) and adds PV snapshot/restore support for CSI volume drivers, moved to GA in v1.20. VolumeSnapshot v1beta1 was deprecated in v1.20 and is now unsupported. Refer to KEP-177: CSI Snapshot and Volume Snapshot GA blog for more information.

@nitishfy
Copy link
Member

nitishfy commented Jun 7, 2022

/assign

@nitishfy
Copy link
Member

nitishfy commented Jun 7, 2022

@sftim I completely agree with the contexts that @xing-yang has shared.

@nitishfy
Copy link
Member

nitishfy commented Jun 8, 2022

New PR #34173 has been raised for this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. triage/needs-information Indicates an issue needs more information in order to work on it.
Projects
None yet
5 participants