Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pull request guides user to url that 404's #35666

Closed
spurin opened this issue Aug 3, 2022 · 3 comments · Fixed by #35670
Closed

New pull request guides user to url that 404's #35666

spurin opened this issue Aug 3, 2022 · 3 comments · Fixed by #35670
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@spurin
Copy link
Contributor

spurin commented Aug 3, 2022

This is a Bug Report

Hi Team,

Hope you're all doing well.

Problem:

When raising a PR for kubernetes/website, the guiding text is as follows -

PLEASE title the FIRST commit appropriately, so that if you squash all your commits into one, the combined commit message makes sense.

For overall help on editing and submitting pull requests, visit:

https://kubernetes.io/docs/contribute/suggest-improvements/

The URL listed, sadly, gives a 404.

Proposed Solution:

Either we fix the target url or update to an alternative location. Thoughts?

Best Regards

James Spurin

@spurin spurin added the kind/bug Categorizes issue or PR as related to a bug. label Aug 3, 2022
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Aug 3, 2022
@sftim
Copy link
Contributor

sftim commented Aug 3, 2022

The URL https://kubernetes.io/docs/contribute/suggesting-improvements/ works. Fixes welcome.

@sftim
Copy link
Contributor

sftim commented Aug 3, 2022

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Aug 3, 2022
@Babapool
Copy link
Member

Babapool commented Aug 3, 2022

I would like to work on this issue. Thanks.
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants