Skip to content

Add bootstrap-5.3.2.min.js dependency for api reference v1.29+ #50466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 14, 2025
Merged

Add bootstrap-5.3.2.min.js dependency for api reference v1.29+ #50466

merged 1 commit into from
Apr 14, 2025

Conversation

spyfly
Copy link
Contributor

@spyfly spyfly commented Apr 11, 2025

Description

Adds bootstrap-5.3.2.min.js to fix example button issue for https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.29/ and higher.

Issue

Closes: #50462

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Apr 11, 2025
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Apr 11, 2025 •
edited
Loading

CLA Signed


The committers listed above are authorized under a signed CLA.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @spyfly!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 11, 2025
@netlify Netlify
Copy link

netlify bot commented Apr 11, 2025

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 8e5a48b
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/67f91f5f45742d00083ce946
😎 Deploy Preview https://deploy-preview-50466--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@spyfly
Copy link
Contributor Author

spyfly commented Apr 11, 2025

✅ Fixed for v1.30, v1.31 and v1.32:

❌ Does not seem to work for Preview v1.29 but that looks like a seperate bug to me.

@tengqm
Copy link
Contributor

tengqm commented Apr 14, 2025

Thanks.
We can bump the version requirement later, for the sake of consistency.
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 14, 2025
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: ef419556f01a006b8b1f33a7da8aa885c40087b5

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tengqm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 14, 2025
@k8s-ci-robot k8s-ci-robot merged commit 9334b60 into kubernetes:main Apr 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 Awaiting requested review from divya-mohan0209

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

show example button does not work on generated api reference due to missing bootstrap-5.3.2.min.js
3 participants
@spyfly @k8s-ci-robot @tengqm