-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making sure that service and ingress are in the same namespace #525
Conversation
…s are in the same namespace Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
PR Analysis
PR Feedback
How to use
|
Signed-off-by: Ben Hirschberg <59160382+slashben@users.noreply.github.com>
Summary:
|
Signed-off-by: YiscahLevySilas1 <yiscahls@armosec.io>
rules/exposure-to-internet/test/failed_with_ingress/input/service.yaml
Dismissed
Show dismissed
Hide dismissed
Summary:
|
PR Type:
Bug fix
PR Description:
This PR addresses a bug in the 'exposure-to-internet' rule where the service and ingress were not verified to belong to the same namespace. This led to false positives in scans. The fix ensures that the service and ingress are in the same namespace, thus reducing the chance of false positives.
PR Main Files Walkthrough:
files:
rules/exposure-to-internet/raw.rego
: Added a condition to verify that the service and ingress belong to the same namespace. This is done by comparing the 'namespace' metadata of both the service and the ingress.User Description:
Overview
Rule "exposure-to-internet" did not verify that the service and ingress are in the same namespace when matching them one to another.
This caused false positives in scans.