Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use golangci-lint and fix all found issues #588

Closed
pkosiec opened this issue May 20, 2022 · 0 comments · Fixed by #593
Closed

Use golangci-lint and fix all found issues #588

pkosiec opened this issue May 20, 2022 · 0 comments · Fixed by #593
Assignees
@pkosiec
Labels
ci Related to CI pipelines enhancement New feature or request
Milestone
v0.13.0

Comments

@pkosiec
Copy link
Collaborator

pkosiec commented May 20, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
This is a follow-up of #582. As the deprecated golint is removed, it would be good to use some linter or a set of linters to improve code quality and maintainability. This can be achieved with golangci-lint.

  • Use golangci-lint on CI pipeline
  • Make sure it can be easily used locally
  • Update contribution instructions to use the linter
  • Fix all found issues (if that's possible within a timebox)
@pkosiec pkosiec added enhancement New feature or request ci Related to CI pipelines labels May 20, 2022
@pkosiec pkosiec added this to the v0.13.0 milestone May 20, 2022
@pkosiec pkosiec self-assigned this May 20, 2022
This was referenced May 20, 2022
Closed
Merged
@pkosiec pkosiec mentioned this issue May 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pkosiec pkosiec

Labels
ci Related to CI pipelines enhancement New feature or request
Projects
None yet
Milestone
v0.13.0
Development

Successfully merging a pull request may close this issue.

Use golangci-lint and resolve all found issues pkosiec/botkube
1 participant
@pkosiec