Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure breaking Cloud API changes are handled gracefully by Admission Controller #15

Open
f1ames opened this issue Nov 2, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation enhancement New feature or request

Comments

@f1ames
Copy link
Contributor

f1ames commented Nov 2, 2023

As mentioned in this comment #12 (comment):

Though I just realise that this will be our inclusion that makes us sensitive to breaking changes. People might be using older Admission Controller versions and we cannot break these queries / mutations ever (or at least until the version becomes unsupported). We need to document this somewhere as so far we have never needed to pay attention to this.

(...) I would start with some internal documentation in the cloud so everyone working on the code is aware of that? And having some automation/tests (either on Cloud or Admission Controller side) checking API compatibility could ensure that we don't break it accidentally.

For the future, there are some solutions like API versioning or providing consistency layer, but it requires some amount of work (and the question if we want to support it like this).

In general how we should handle breaking changes in Cloud API endpoints used by Admission Controller? Should we even allow for such or make sure backwards compatibility is always there?

@f1ames f1ames added documentation Improvements or additions to documentation enhancement New feature or request labels Nov 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant