fix: show modal error instead of closing modal

kubeshop · Nov 16, 2023 · 63ac1a9 · 63ac1a9
1 parent 8a08675
commit 63ac1a9
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 12 deletions.
diff --git a/packages/web/src/components/pages/Executors/ExecutorsList/AddExecutorsModal.tsx b/packages/web/src/components/pages/Executors/ExecutorsList/AddExecutorsModal.tsx
@@ -55,16 +55,16 @@ const AddExecutorsModal: React.FC = () => {
 
     createExecutor(body)
       .then(displayDefaultNotificationFlow)
-      .then(res => openDetails(res.data.metadata.name))
+      .then(res => {
+        openDetails(res.data.metadata.name);
+        close();
+      })
       .catch(err => {
         setError(err);
 
         if (!inTopInViewport && topRef && topRef.current) {
           topRef.current.scrollIntoView();
         }
-      })
-      .finally(() => {
-        close();
       });
   };
 

diff --git a/packages/web/src/components/pages/Sources/SourcesList/AddSourceModal.tsx b/packages/web/src/components/pages/Sources/SourcesList/AddSourceModal.tsx
@@ -61,16 +61,16 @@ const AddSourceModal: React.FC = () => {
 
     createSource(body)
       .then(displayDefaultNotificationFlow)
-      .then(res => openDetails(res.data.metadata.name))
+      .then(res => {
+        openDetails(res.data.metadata.name);
+        close();
+      })
       .catch(err => {
         setError(err);
 
         if (!inTopInViewport && topRef && topRef.current) {
           topRef.current.scrollIntoView();
         }
-      })
-      .finally(() => {
-        close();
       });
   };
 

diff --git a/packages/web/src/components/pages/Triggers/TriggersList/AddTriggerModal/AddTriggerModal.tsx b/packages/web/src/components/pages/Triggers/TriggersList/AddTriggerModal/AddTriggerModal.tsx
@@ -82,16 +82,16 @@ const AddTriggerModal: React.FC = () => {
     };
     createTrigger(body)
       .then(displayDefaultNotificationFlow)
-      .then(res => openDetails(res.data.name))
+      .then(res => {
+        openDetails(res.data.name);
+        close();
+      })
       .catch(err => {
         setError(err);
 
         if (!inTopInViewport && topRef && topRef.current) {
           topRef.current.scrollIntoView();
         }
-      })
-      .finally(() => {
-        close();
       });
   };