fix: security alerts (#932)

* fix: update dependencies * fix: security alerts
kubeshop · Nov 8, 2023 · 78c8f58 · 78c8f58
1 parent 0f8f9db
commit 78c8f58
Show file tree

Hide file tree

Showing 5 changed files with 59 additions and 92 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/web/src/components/atoms/ExternalLink/ExternalLink.tsx b/packages/web/src/components/atoms/ExternalLink/ExternalLink.tsx
@@ -2,7 +2,7 @@ const ExternalLink: React.FC<React.AnchorHTMLAttributes<HTMLAnchorElement>> = pr
   const {children, ...rest} = props;
 
   return (
-    <a target="_blank" {...rest}>
+    <a target="_blank" rel="noopener" {...rest}>
       {children}
     </a>
   );

diff --git a/packages/web/src/components/molecules/LabelsSelect/utils.ts b/packages/web/src/components/molecules/LabelsSelect/utils.ts
@@ -13,5 +13,4 @@ export const composeLabels = (labelsObject?: Record<string, string>): string[] =
   return Object.entries(labelsObject || {}).map(([key, value]) => `${key}${value ? `:${value}` : ''}`);
 };
 
-export const labelRegex =
-  /^(([A-Za-z0-9][-A-Za-z0-9_./]*)?[A-Za-z0-9]:\s?(([A-Za-z0-9][-A-Za-z0-9_.]*)?[A-Za-z0-9])+)$/;
+export const labelRegex = /^[a-z0-9]([a-z0-9_./-]*[a-z0-9])?:\s?[a-z0-9]([a-z0-9_.-]*[a-z0-9])?$/i;
diff --git a/packages/web/src/plugins/ai-insights-promo/components/AiInsightsTab.tsx b/packages/web/src/plugins/ai-insights-promo/components/AiInsightsTab.tsx
@@ -1,5 +1,7 @@
 import {ReactComponent as LockedIcon} from '@assets/lockedIcon.svg';
 
+import ExternalLink from '@atoms/ExternalLink';
+
 import {Button, Text} from '@custom-antd';
 
 import Colors from '@styles/Colors';
@@ -15,10 +17,7 @@ const AiInsightsTab = () => (
       <Text className="big bold"> This feature is available only in Testkube Cloud.</Text>
       <Text color={Colors.slate400}>
         Start using Testkube Cloud to get AI insights for your test executions, as well as other exclusive features.
-        <a href={externalLinks.testkubeCloud} target="_blank">
-          {' '}
-          Learn more
-        </a>
+        <ExternalLink href={externalLinks.testkubeCloud}> Learn more</ExternalLink>
       </Text>
       <Button
         type="primary"

diff --git a/packages/web/src/plugins/sider-support/plugin.tsx b/packages/web/src/plugins/sider-support/plugin.tsx
@@ -3,6 +3,8 @@ import {Popover} from 'antd';
 
 import {createPlugin, external} from '@testkube/plugins';
 
+import ExternalLink from '@atoms/ExternalLink';
+
 import Text from '@custom-antd/Typography/Text';
 
 import {DropdownListItem} from '@organisms/Sider/Sider.styled';
@@ -31,25 +33,25 @@ export default createPlugin('dashboard/sider-support')
           content={
             <>
               <DropdownListItem>
-                <a href={externalLinks.documentation} target="_blank">
+                <ExternalLink href={externalLinks.documentation}>
                   <Text color={Colors.slate300} className="regular middle">
                     Documentation
                   </Text>
-                </a>
+                </ExternalLink>
               </DropdownListItem>
               <DropdownListItem>
-                <a href={tk.data.discordUrl} target="_blank">
+                <ExternalLink href={tk.data.discordUrl}>
                   <Text color={Colors.slate300} className="regular middle">
                     Discord community
                   </Text>
-                </a>
+                </ExternalLink>
               </DropdownListItem>
               <DropdownListItem>
-                <a href={externalLinks.github} target="_blank">
+                <ExternalLink href={externalLinks.github}>
                   <Text color={Colors.slate300} className="regular middle">
                     GitHub
                   </Text>
-                </a>
+                </ExternalLink>
               </DropdownListItem>
             </>
           }