-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cache the Testkube binary in the GitHub Action #4939
Comments
Fixed with kubeshop/setup-testkube#4 |
Hi @devcatalin , @rangoo94 Thank you for the concise support regarding this feature. I've recently had the opportunity to review your implementation, and I'd like to share some comments from my perspective. This approach is only viable once Testkube is successfully installed within the GitHub Actions (GA) workflow. This means the cache is effective only when Testkube has been installed. There's a scenario where GitHub.io might impose rate limits, rejecting installation from anonymous access, rendering this caching implementation ineffective. I propose we implement an additional feature: allowing users to define the GitHub.io Personal Access Token (PAT) within the action.yaml. This PAT could then be used to authorize with GitHub.io, overcoming potential rate-limiting issues. For more details about the token property I mentioned, you can refer to https://github.com/actions/setup-python. The combination of a GitHub.io token and caching would be highly beneficial. 👍 |
Also, once the |
Hi @itsme2980! Thank you, regarding the first proposal, I have added a new ticket for that - #4965. When it comes to cache - you won't find the cache, as we are using built-in GitHub's mechanism for caching binaries, and it's working only on self-hosted workers (@actions/tool-cache). We cannot use the actual GH cache, as it's not possible from the action level. If you want to avoid requests to the GH API, you may also use |
We should cache the Testkube binary using @actions/tool-cache. You may find an example in
azure/setup-kubectl
.At the moment we are calling GitHub API each time, which results in the rate limit errors for frequent workflows.
The text was updated successfully, but these errors were encountered: