Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs say dashboard is included, but it isn't #5622

Open
davidkarlsen opened this issue Jun 30, 2024 · 8 comments
Open

Docs say dashboard is included, but it isn't #5622

davidkarlsen opened this issue Jun 30, 2024 · 8 comments
Assignees
Labels
Bug Created by Linear-GitHub Sync

Comments

@davidkarlsen
Copy link

Describe the bug

Docs at https://github.com/kubeshop/testkube-dashboard and readme in chart say dashboard is included in main testkube chart, but it isn't.

To Reproduce
Steps to reproduce the behavior:

  1. install with testkube-dashboard.enabled=true
  2. Observe that no dashboard is installed

Expected behavior
Docs should match reality.

Version / Cluster

  • Which testkube version?
  • What Kubernetes cluster? (e.g. GKE, EKS, Openshift etc, local KinD, local Minikube)
  • What Kubernetes version?

Screenshots
If applicable, add CLI commands/output to help explain your problem.

Additional context
Add any other context about the problem here.

@davidkarlsen davidkarlsen added the bug 🐛 Something is not working as should be label Jun 30, 2024
@vsukhin
Copy link
Collaborator

vsukhin commented Jun 30, 2024

hey @davidkarlsen dashboard is excluded from OSS edition since 1.17.0

@davidkarlsen
Copy link
Author

@vsukhin yes, and docs should reflect this. For instance the readme has a lot of references to this

@vsukhin
Copy link
Collaborator

vsukhin commented Jul 1, 2024

make sense @WitoDelnat and @olensmar to note

@olensmar
Copy link
Member

olensmar commented Jul 1, 2024

thanks @davidkarlsen for pointing this out - our bad for not updating the README accordingly.. PR coming up!

@olensmar olensmar self-assigned this Jul 1, 2024
@olensmar
Copy link
Member

olensmar commented Jul 1, 2024

@davidkarlsen I've added another note to the top of the README at https://github.com/kubeshop/testkube-dashboard?tab=readme-ov-file - do you think this is sufficient?

@davidkarlsen
Copy link
Author

davidkarlsen commented Jul 1, 2024

@olensmar Hello again Mr. soap-ui :)
It's also in the chart readmes:

| testkube-dashboard.affinity | object | `{}` | Note: podAffinityPreset, podAntiAffinityPreset, and nodeAffinityPreset will be ignored when it's set |
| testkube-dashboard.apiServerEndpoint | string | `""` | Testkube API Server endpoint |
| testkube-dashboard.autoscaling.annotations | object | `{}` | Specific autoscaling annotations |
| testkube-dashboard.autoscaling.enabled | bool | `false` | Enable autoscaling for Testkube dashboard deployment |

@davidkarlsen
Copy link
Author

And some reference here too: https://docs.testkube.io/articles/install/install-with-helm#domain

@linear linear bot added Bug Created by Linear-GitHub Sync and removed bug 🐛 Something is not working as should be labels Jul 2, 2024
@vsukhin
Copy link
Collaborator

vsukhin commented Jul 3, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Created by Linear-GitHub Sync
Projects
None yet
Development

No branches or pull requests

3 participants