Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt user to choose a project if repository belongs to multiple ones in the Cloud #91

Open
f1ames opened this issue Feb 1, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@f1ames
Copy link
Contributor

f1ames commented Feb 1, 2024

The proposal here is to adjust the project matching logic to prompt user to choose the project if the active repo belongs to more than one projects in the Cloud/Enterprise.

User choice should be persisted (maybe?) for future sessions. And along with that we should provide command (e.g. Switch Project) to easily allow changing it.


And a bit of context:

Matching project is used to get policy and suppressions for active repo.

At the beginning we made some assumptions about matching local repository to remote project. It was done based on prChecks flag and if there was no project with such, first owner project of the repository will be used (also assuming that having repo in multiple projects is an edge case, or... maybe it wasn't possible back then 🤔).

At some point we deprecated prChecks flag for matching repos and so left with the logic matching first owner project of the repository.

And what we have now is not perfect. It came apparent when working with fingerprint suppressions that "kind of guessing project" we have now may be problematic and confusing, resulting also in unwanted suppressions in other projects.

We have partial workaround, which is monokle.project config, but it's not really user friendly.

@f1ames f1ames added the enhancement New feature or request label Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant