Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Front-end] avoid using API tojson and tojenkinsfile #714

Closed
Tracked by #734 ...
LinuxSuRen opened this issue Jul 4, 2022 · 5 comments · Fixed by #902
Closed
Tracked by #734 ...

[Front-end] avoid using API tojson and tojenkinsfile #714

LinuxSuRen opened this issue Jul 4, 2022 · 5 comments · Fixed by #902
Assignees
Milestone

Comments

@LinuxSuRen
Copy link
Member

No description provided.

@LinuxSuRen
Copy link
Member Author

/area console

@LinuxSuRen
Copy link
Member Author

LinuxSuRen commented Jul 12, 2022

For this issue, the front-end needs to abandon two APIs:

  • v1alpha2/tojenkinsfile
  • v1alpha2/tojson

then you could update the Jenkinsfile with JSON or raw format with the following API. Please feel free to read more details about this API from the swagger.

  • /v1alpha3/devops/{devops}/pipelines/{pipeline}/jenkinsfile

you could get the JSON format of the Jenkinsfile from annotation with key pipeline.devops.kubesphere.io/jenkinsfile

@bunnymiao
Copy link

/assign

@chilianyi
Copy link
Contributor

截屏2023-01-29 23 16 07

截屏2023-01-30 11 40 50

There are still tojson api call,need to remove.

@chilianyi
Copy link
Contributor

chilianyi commented Feb 9, 2023

add jenkinsfile.validate to annotation
valid values are success and failure

if failure, show like this:
截屏2023-01-30 14 53 37

if there is no jenkinsfile.validate, due as success.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants