Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude tinycore tests from s390x e2e test suite #3627

Open
cfilleke opened this issue Feb 4, 2025 · 3 comments · May be fixed by #3628
Open

Exclude tinycore tests from s390x e2e test suite #3627

cfilleke opened this issue Feb 4, 2025 · 3 comments · May be fixed by #3628

Comments

@cfilleke
Copy link
Member

cfilleke commented Feb 4, 2025

Is your feature request related to a problem? Please describe:
When running s390x e2e tests, uses tinycore image which is not supported on s390x

Describe the solution you'd like:
label tinycore tests so we can exclude them explicitly from s390x e2e test suite

Describe alternatives you've considered:
currently we use a work-around which is to use a regex in the manual ginkgo test call to exclude tinycore image; it's preferable to have it explicitly labelled; considered building tinycore image for s390x but that would be a bigger and external project with more permissions required.

Additional context:
only applies to s390x architecture.

@akalenyu
Copy link
Collaborator

akalenyu commented Feb 4, 2025

uses tinycore image which is not supported on s390x

not sure what that means? there are no VMs created in CDI tests so any image should work just fine

@awels
Copy link
Member

awels commented Feb 4, 2025

Right on the CDI side we are only interested in the bytes being written from the source to the target. We don't even know about VMs or what they are in CDI. If there are failures on s390x in the CDI test suite there is some other reason.

@cfilleke
Copy link
Member Author

cfilleke commented Feb 4, 2025

The tests were balking at using the image provided, but it looks like @Davo911 has built an image that the s390x CDI will recognize and move around now -- he's trying to get it to start up busybox or get a shell running in it (since it's just the kernel plus some basic tools at its simplest) anyway. But yah we could use an s390x formatted VM for the tests that are there now, even if it doesn't boot or bring up a shell.

@Davo911 Davo911 linked a pull request Feb 5, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants