raise an alert when the descheduler is not correctly configured #3100
Conversation
kubevirt-bot
added
release-note
Pull Request Test Coverage Report for Build 11052150087Details
💛 - Coveralls |
tiraboschi
force-pushed
the
check_descheduler_conf
branch
from
b6e8810
to
5721d8b
Compare
tiraboschi
force-pushed
the
check_descheduler_conf
branch
6 times, most recently
from
bb4642a
to
6c93497
Compare
tiraboschi
changed the title
kubevirt-bot
removed
the
do-not-merge/work-in-progress
tiraboschi
force-pushed
the
check_descheduler_conf
branch
2 times, most recently
from
8392352
to
fb50a15
Compare
|
/lgtm
of course we can do it later just small nits. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
tiraboschi
force-pushed
the
check_descheduler_conf
branch
from
fb50a15
to
eca9343
Compare
tiraboschi
force-pushed
the
check_descheduler_conf
branch
from
eca9343
to
fb99f62
Compare
done |
tiraboschi
force-pushed
the
check_descheduler_conf
branch
from
4c89d83
to
e34c69a
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nunnatsa The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
tiraboschi
force-pushed
the
check_descheduler_conf
branch
from
e34c69a
to
0221f7e
Compare
Descheduler is an optional operator and it's not installed by default nor as a dependency of HCO. When installed it can work on a cluster with KubeVirt only if configured enabling devEnableEvictionsInBackground profileCustomization that is disabled by default. HCO will check if the descheduler is there, and if so it will check its configuration. If the descheduler is misconfigured for the KubeVirt use case, HCO will trigger an alert making the cluster admin aware. HCO is not directly amending the descheduler configuration since it's an external independent operator and directly controlling it is not a safe practice (it could bring to infinite loops fighting with other operators and so on). Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>
tiraboschi
force-pushed
the
check_descheduler_conf
branch
from
0221f7e
to
9a33f14
Compare
|
|
hco-e2e-upgrade-prev-operator-sdk-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-operator-sdk-aws, ci/prow/hco-e2e-operator-sdk-gcp, ci/prow/hco-e2e-upgrade-prev-operator-sdk-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
ignoring slightly reduce coverage due to infra code for the two additional controllers |
|
@tiraboschi: Overrode contexts on behalf of tiraboschi: coverage/coveralls In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-upgrade-prev-operator-sdk-sno-azure lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-prev-operator-sdk-sno-aws In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/retest |
|
@tiraboschi: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
hco-e2e-kv-smoke-gcp lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-kv-smoke-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
hco-e2e-upgrade-operator-sdk-aws lane succeeded. |
|
@hco-bot: Overrode contexts on behalf of hco-bot: ci/prow/hco-e2e-upgrade-operator-sdk-azure, ci/prow/hco-e2e-upgrade-operator-sdk-sno-azure In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-1.13 |
|
@tiraboschi: new pull request created: #3118 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
Descheduler is an optional operator and it's not installed by default nor as a dependency of HCO. When installed it can work on a cluster with
KubeVirtonly if configured enablingdevEnableEvictionsInBackgroundprofileCustomization that is disabled by default.HCO will check if the descheduler is there, and if so it will check its configuration.
If the descheduler is misconfigured for the KubeVirt use case, HCO will trigger an alert making the cluster admin aware.
HCO is not directly amending the descheduler configuration since it's an external independent operator and directly controlling it is not a safe practice (it could bring to infinite loops fighting with other operators and so on).
Reviewer Checklist
Jira Ticket:
Release note: