-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pkg/monitoring/metrics: add new alert for vms using outdated machine type #3106
base: main
Are you sure you want to change the base?
pkg/monitoring/metrics: add new alert for vms using outdated machine type #3106
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
6479be4
to
d011735
Compare
Is HCO the right place for th his metric? HCO does not know VMs at all and dhould not monitor them. /hold |
d011735
to
f60673b
Compare
f60673b
to
6f66639
Compare
6f66639
to
b4385e1
Compare
Pull Request Test Coverage Report for Build 11310572661Details
💛 - Coveralls |
b4385e1
to
e2300e3
Compare
27e58ff
to
06e9d6c
Compare
@dasionov: The specified target(s) for
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/cc @machadovilaca |
db4b317
to
b786e1f
Compare
c37373a
to
cc93761
Compare
cc93761
to
c502d6a
Compare
c502d6a
to
e771199
Compare
/cc @enp0s3 |
6e44f0a
to
96d49d8
Compare
96d49d8
to
9dc6ff6
Compare
/retest-required |
/retest |
9dc6ff6
to
49034b3
Compare
- Introduce new alert for VMs using an outdated machine type. - Machine types are considered outdated if they are no longer compatible due to changes in the virt-launcher OS version. These VMs must be updated with supported machine types to ensure compatibility and avoid potential issues. - Add a functional test to verify the alert is triggered when VMs with outdated machine types are detected. Signed-off-by: Daniel Sionov <dsionov@redhat.com>
49034b3
to
037c422
Compare
Quality Gate passedIssues Measures |
@dasionov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
and also I have some concerns if it makes sense to check for RHEL versions here |
What this PR does / why we need it:
This PR introduces a new Prometheus alert for virtual machines (VMs) in the cluster that require a machine type update. For instance, VMs configured with the machine type set to RHEL 8 would be flagged as outdated. This is because the base image of the virt-launcher will transition to RHEL 10, which introduces breaking changes incompatible with older machine types.
Depends-On #3132, kubevirt/kubevirt#13010
Reviewer Checklist
Release note: