Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README: Add missing namespace to developer workflow #3143

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

jschintag
Copy link
Contributor

What this PR does / why we need it:

When deploying HCO via operator-sdk, the run command should contain the correct
namespace, as it otherwise fails.
Additionally, my IDE removed the trailing white spaces, so i committed that as a separate commit.

Reviewer Checklist

Reviewers are supposed to review the PR for every aspect below one by one. To check an item means the PR is either "OK" or "Not Applicable" in terms of that item. All items are supposed to be checked before merging a PR.

  • PR Message
  • Commit Messages
  • How to test
  • Unit Tests
  • Functional Tests
  • User Documentation
  • Developer Documentation
  • Upgrade Scenario
  • Uninstallation Scenario
  • Backward Compatibility
  • Troubleshooting Friendly

Jira Ticket:

NONE

Release note:

NONE

When deploying HCO via operator-sdk, the run command should contain the correct
namespace, as it otherwise fails.

Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
Signed-off-by: Jan Schintag <jan.schintag@de.ibm.com>
@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. size/S labels Oct 21, 2024
Copy link

sonarcloud bot commented Oct 21, 2024

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11436501081

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.01%) to 72.445%

Files with Coverage Reduction New Missed Lines %
controllers/operands/quickStart.go 1 82.14%
Totals Coverage Status
Change from base Build 11386986558: -0.01%
Covered Lines: 6039
Relevant Lines: 8336

💛 - Coveralls

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Oct 22, 2024
@tiraboschi
Copy link
Member

/approve

@kubevirt-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tiraboschi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 22, 2024
@kubevirt-bot kubevirt-bot merged commit 1fd456c into kubevirt:main Oct 22, 2024
15 checks passed
@jschintag jschintag deleted the fix-developer-deploy branch October 22, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants