Skip to content

Commit 08b393e

Browse files
ConradIrwinkubkon
authored andcommitted
Remove Chat (zed-industries#37789)
At RustConf we were demo'ing zed, and it continually popped open the chat panel. We're usually inured to this because the Chat panel doesn't open unless a Guest is in the channel, but it made me sad that we were showing a long stream of vacuous comments and unresponded to questions on every demo screen. We may bring chat back in the future, but we need more thought on the UX, and we need to rebuild the backend to not use the existing collab server that we're trying to move off of. Release Notes: - Removed the chat feature from Zed (Sorry to the 5 of you who use this on the regular!)
1 parent 624d703 commit 08b393e

34 files changed

+54
-5766
lines changed

Cargo.lock

Lines changed: 0 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

assets/settings/default.json

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -740,16 +740,6 @@
740740
// Default width of the collaboration panel.
741741
"default_width": 240
742742
},
743-
"chat_panel": {
744-
// When to show the chat panel button in the status bar.
745-
// Can be 'never', 'always', or 'when_in_call',
746-
// or a boolean (interpreted as 'never'/'always').
747-
"button": "when_in_call",
748-
// Where to dock the chat panel. Can be 'left' or 'right'.
749-
"dock": "right",
750-
// Default width of the chat panel.
751-
"default_width": 240
752-
},
753743
"git_panel": {
754744
// Whether to show the git panel button in the status bar.
755745
"button": true,

crates/auto_update_ui/src/auto_update_ui.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
use auto_update::AutoUpdater;
2-
use client::proto::UpdateNotification;
32
use editor::{Editor, MultiBuffer};
43
use gpui::{App, Context, DismissEvent, Entity, Window, actions, prelude::*};
54
use http_client::HttpClient;
@@ -138,6 +137,8 @@ pub fn notify_if_app_was_updated(cx: &mut App) {
138137
return;
139138
}
140139

140+
struct UpdateNotification;
141+
141142
let should_show_notification = updater.read(cx).should_show_update_notification(cx);
142143
cx.spawn(async move |cx| {
143144
let should_show_notification = should_show_notification.await?;

crates/channel/Cargo.toml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,9 @@ gpui.workspace = true
2525
language.workspace = true
2626
log.workspace = true
2727
postage.workspace = true
28-
rand.workspace = true
2928
release_channel.workspace = true
3029
rpc.workspace = true
3130
settings.workspace = true
32-
sum_tree.workspace = true
3331
text.workspace = true
3432
time.workspace = true
3533
util.workspace = true

crates/channel/src/channel.rs

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,11 @@
11
mod channel_buffer;
2-
mod channel_chat;
32
mod channel_store;
43

54
use client::{Client, UserStore};
65
use gpui::{App, Entity};
76
use std::sync::Arc;
87

98
pub use channel_buffer::{ACKNOWLEDGE_DEBOUNCE_INTERVAL, ChannelBuffer, ChannelBufferEvent};
10-
pub use channel_chat::{
11-
ChannelChat, ChannelChatEvent, ChannelMessage, ChannelMessageId, MessageParams,
12-
mentions_to_proto,
13-
};
149
pub use channel_store::{Channel, ChannelEvent, ChannelMembership, ChannelStore};
1510

1611
#[cfg(test)]
@@ -19,5 +14,4 @@ mod channel_store_tests;
1914
pub fn init(client: &Arc<Client>, user_store: Entity<UserStore>, cx: &mut App) {
2015
channel_store::init(client, user_store, cx);
2116
channel_buffer::init(&client.clone().into());
22-
channel_chat::init(&client.clone().into());
2317
}

0 commit comments

Comments
 (0)