Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

events.k8s.io/v1beta1 removal in Kubernetes 1.25 #414

Closed
chipzoller opened this issue Nov 10, 2022 · 6 comments · Fixed by #416
Closed

events.k8s.io/v1beta1 removal in Kubernetes 1.25 #414

chipzoller opened this issue Nov 10, 2022 · 6 comments · Fixed by #416

Comments

@chipzoller
Copy link

What would you like to be added:

Adapt kuttl to use new API version for Events in Kubernetes 1.25+

Why is this needed:

Test output shows kuttl is still getting events using the v1beta1 API version. As indicated, this is deprecated in 1.22 and removed in 1.25.

Warning: events.k8s.io/v1beta1 Event is deprecated in v1.22+, unavailable in v1.25+
@iblancasa
Copy link
Collaborator

I think it is adapted:

err = t.collectEventsBeta1(cl, namespace)

It just checks if v1beta1 is available and, if not, checks for v1 API. That makes sense because you can use KUTTL with older k8s versions.

@iblancasa
Copy link
Collaborator

Also, duplicated #373

@eddycharly
Copy link
Contributor

Shouldn't it be done the other way around ?
Try with v1 first, then fall back to v1beta1 if it's not available ?

@iblancasa
Copy link
Collaborator

Maybe it makes sense to check both... instead being a fallback. I don't have a strong opinion about that.

@eddycharly
Copy link
Contributor

If v1 is ok no need to call v1beta1, they will expose the same events (only the endpoints are different).

@chipzoller
Copy link
Author

Right, v1 should be checked first, if not available, check v1beta1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants