Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

パスワードとパスワード確認が空白のまま更新ボタンを押せる #9

Open
kudojp opened this issue Apr 25, 2020 · 0 comments
Labels
bug Something isn't working

Comments

@kudojp
Copy link
Owner

kudojp commented Apr 25, 2020

#8 の実装時に(そんなにクリティカルじゃないので)skipした問題

  • 既にパスワードを設定済みのuserがEdit Passwordページでpasswordとpassword confirmationを空にして正しいcurrent passwordのみを入力してsubmitしてもエラーを吐かない(ただしencrypted_passwordの更新もされない)
  • update_with_passwordの実装が問題

image

@kudojp kudojp changed the title 既にパスワードを設定済みのuserga パスワードとパスワード確認が空白のまま更新ボタンを押せる Apr 25, 2020
@kudojp kudojp added the bug Something isn't working label Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant