Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support TypeScript? #32

Open
koddr opened this issue Jul 3, 2018 · 6 comments
Open

Support TypeScript? #32

koddr opened this issue Jul 3, 2018 · 6 comments

Comments

@koddr
Copy link

koddr commented Jul 3, 2018

Hello.

What about supporting TypeScript? When I try to use, I see this:

 Try `npm install @types/reactbulma` if it exists or add a new declaration (.d.ts) file containing `declare module 'reactbulma';`

And, of cause, npm install @types/reactbulma do nothing.
Would be great to start supporting TS at middle of 2018 for your awesome package..

@kulakowka
Copy link
Owner

I don't have an experience with TypeScript. But i will be glad if you send a PR.

@thib92
Copy link

thib92 commented Aug 2, 2018

Hi ! I'm currently working on implementing typings for this project. I will submit a PR when it is ready 😄
Since the repo isn't created in TS, the whole props typings must be done by hand.

@thib92
Copy link

thib92 commented Aug 13, 2018

PR open #34 😄

@loopmode
Copy link

Too bad there is no progress whatsoever here, since there already is a pretty decent PR.
I just started typing this out manually for a pet project, but I'll stop that.
I will either contribute the proposed typings to @types/reactbulma or fork this repo and publish it under my own npm scope.

@thib92
Copy link

thib92 commented Sep 12, 2019

@loopmode since the PR isn’t merged into the repo, feel free to take the typings I made and propose them on DefinitelyTyped. I don’t use this project anymore.

This is probably the best thing to do since everyone using this package with TS will get the typings! Publishing it under your own NPM package means you’ll have to maintain a fork with all the updates!

@loopmode
Copy link

@thib92 what updates?
Just kidding :D of course you're right, @types/reactbulma would be much preferable. I just have to get familiar with the DefinitelyTyped repo and workflow. They do have good documentation and recommendations, already looked into. I just know from GitHub what a massive repo it is and have some respect, but it shouldn't be a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants