Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler): return undefined for getScriptVersion #1641

Merged
merged 1 commit into from
May 14, 2020
Merged

fix(compiler): return undefined for getScriptVersion #1641

merged 1 commit into from
May 14, 2020

Conversation

ahnpnl
Copy link
Collaborator

@ahnpnl ahnpnl commented May 14, 2020

Summary

Close #1639

Test plan

Not sure how to test this. But from code perspective, using ! operator is wrong.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

N.A.

@ahnpnl ahnpnl requested a review from kulshekhar as a code owner May 14, 2020 15:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4835

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.04%) to 92.853%
Totals Coverage Status
Change from base Build 4834: -0.04%
Covered Lines: 1061
Relevant Lines: 1096
💛 - Coveralls

@ahnpnl ahnpnl merged commit 6851b8e into kulshekhar:master May 14, 2020
@ahnpnl ahnpnl deleted the fix-compiler branch May 14, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulshekhar kulshekhar kulshekhar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@ahnpnl @coveralls @kulshekhar