Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Things to do for version 23 release? #589

Closed
trivikr opened this issue Jun 20, 2018 · 7 comments · Fixed by #600
Closed

Things to do for version 23 release? #589

trivikr opened this issue Jun 20, 2018 · 7 comments · Fixed by #600

Comments

@trivikr
Copy link
Contributor

trivikr commented Jun 20, 2018

  • Issue
    Jest v23 was released on 2018-05-29 (blog post)
    There's no equivalent v23 for ts-jest (releases) as of 2018-06-19

  • Expected behavior
    There should be v23 of ts-jest corresponding to v23 of jest as per versioning in README.md

I'm very eager to update to Jest v23 in my projects.
What are the pending tasks to release v23 of ts-jest? I might be able to help

@kulshekhar
Copy link
Owner

@trivikr sorry about this. I'm completely swamped with work right now.

If the latest master can be tested against Jest 23 and a PR sent for that, I'll be more than happy to merge it in and publish a new release

@trivikr
Copy link
Contributor Author

trivikr commented Jun 20, 2018

Thanks @kulshekhar for the response.
What's the procedure to test latest master against Jest 23?

@kulshekhar
Copy link
Owner

kulshekhar commented Jun 20, 2018

  • clone ts-jest
  • create a branch for the upgrade
  • upgrade the jest related dependencies in package.json
  • install the dependencies
  • run yarn test to check whether the upgrade breaks anything
  • In a project using ts-jest, change package.json to use this cloned/upgraded version of ts-jest.
  • run the project's tests to check whether the upgrade breaks anything
  • if sending a PR to upgrade, bump the package.json version to 23.0.0

@trivikr
Copy link
Contributor Author

trivikr commented Jun 20, 2018

The commits for ts-jest v21 -> v22 can be viewed here https://github.com/kulshekhar/ts-jest/commits/master?after=4ddf5b5dab99b5a68fba8f12ddd91baaa668d3db+225

I'll try to find time this weekend to work on this.

@GeeWee
Copy link
Collaborator

GeeWee commented Jun 30, 2018

I'm reopening this - we need to write a changelog with the breaking changes.

@kulshekhar
Copy link
Owner

given that 23 has been released, can this be in a different issue?

@GeeWee
Copy link
Collaborator

GeeWee commented Jun 30, 2018

I've opened #601

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants