Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add localityAwareLoadBalancing to TrafficRoute #3456

Closed
lahabana opened this issue Dec 9, 2021 · 6 comments
Closed

Add localityAwareLoadBalancing to TrafficRoute #3456

lahabana opened this issue Dec 9, 2021 · 6 comments
Labels
area/policies kind/feature New feature kind/improvement Improvement on an existing feature triage/duplicated already exists

Comments

@lahabana
Copy link
Contributor

lahabana commented Dec 9, 2021

Description

We should be able to set localityAwareLoadBalancing as an option in the TrafficRoute.
This is mainly because you might not want all or none the services to have the same behaviour.

This is especially useful for prometheus federation (you want to stick to a zone even if it's unavailable).
@lahabana lahabana added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature kind/improvement Improvement on an existing feature area/policies triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 9, 2021
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 13, 2022
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jan 13, 2022
@lahabana lahabana mentioned this issue Feb 9, 2022
Closed
@github-actions
Copy link
Contributor

This issue was inactive for 30 days it will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant please comment on it promptly or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 13, 2022
@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Jul 5, 2022
@lahabana lahabana mentioned this issue Aug 2, 2022
Closed
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Oct 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 4, 2022

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lahabana lahabana removed the triage/stale Inactive for some time. It will be triaged again label Oct 5, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jan 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 4, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz
Copy link
Contributor

Duplicate of #2689
It's not 100% clear if we want to add it to the new MeshHTTPRoute

@jakubdyszkiewicz jakubdyszkiewicz closed this as not planned Won't fix, can't repro, duplicate, stale Jan 4, 2023
@jakubdyszkiewicz jakubdyszkiewicz added triage/rotten closed due to lack of information for too long, rejected feature... and removed triage/accepted The issue was reviewed and is complete enough to start working on it triage/stale Inactive for some time. It will be triaged again labels Jan 4, 2023
@lahabana lahabana added triage/duplicated already exists and removed triage/rotten closed due to lack of information for too long, rejected feature... labels Jan 4, 2023
@lahabana
Copy link
Contributor Author

lahabana commented Jan 4, 2023

I think we wanted to add it to something different as this is cluster based. I think it's a similar problem as load balancer types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/policies kind/feature New feature kind/improvement Improvement on an existing feature triage/duplicated already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lahabana @jakubdyszkiewicz