Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pagination for /meshes/:mesh/dataplanes+insights returns wrong total #7801

Closed
kleinfreund opened this issue Sep 20, 2023 · 0 comments · Fixed by #7803
Closed

Pagination for /meshes/:mesh/dataplanes+insights returns wrong total #7801

kleinfreund opened this issue Sep 20, 2023 · 0 comments · Fixed by #7803
Labels
kind/bug A bug triage/pending This issue will be looked at on the next triage meeting

Comments

@kleinfreund
Copy link
Contributor

kleinfreund commented Sep 20, 2023 •
edited
Loading

What happened?

The response for /meshes/:mesh/dataplanes+insights doesn’t return the correct total value.

For a mesh with 250 DPPs, the endpoint returns 50 DPPs (which is correct as we by default request 50 items with the size parameter), but it also returns total: 50 which is not correct. It should be 250.

Possibly related to https://github.com/kumahq/kuma/blob/master/pkg/api-server/dataplane_overview_endpoints.go#L122.
@kleinfreund kleinfreund added kind/bug A bug triage/pending This issue will be looked at on the next triage meeting labels Sep 20, 2023
@jakubdyszkiewicz jakubdyszkiewicz mentioned this issue Sep 20, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug A bug triage/pending This issue will be looked at on the next triage meeting
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(api-server): dataplane overview pagination jakubdyszkiewicz/kuma
1 participant
@kleinfreund