Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Print brew upgrade instructions when kurtosis cli users are using an outdated version of kurtosis cli #1130

Closed
leeederek opened this issue Aug 18, 2023 · 3 comments
Labels

Comments

@leeederek
Copy link
Contributor

Background & motivation

Kurtosis releases updates quite often. This is awesome, but this also means users will likely be using out-of-date versions of Kurtosis.

Currently the WARN looks like this:

WARN[2023-08-18T12:14:39+01:00] You are running an old version of the Kurtosis CLI; we suggest you to update it to the latest version, '0.81.9'
WARN[2023-08-18T12:14:39+01:00] You can manually upgrade the CLI tool following these instructions: https://docs.kurtosis.com/install#upgrading

Desired behaviour

When I am using an outdated version of Kurtosis CLI, I would like the terminal to print the following:

WARN[2023-08-18T12:14:39+01:00] You are running an old version of the Kurtosis CLI; we suggest you to update it to the latest version, '0.81.9'
WARN[2023-08-18T12:14:39+01:00] Upgrade using: brew update && brew upgrade kurtosis-tech/tap/kurtosis-cli && kurtosis engine restart. For other ways to upgrade, visit: https://docs.kurtosis.com/install#upgrading

How important is this to you?

Nice to have; this feature would make using Kurtosis more enjoyable.

@github-actions github-actions bot added the nice to have Nice to have feature label Aug 18, 2023
@leeederek
Copy link
Contributor Author

One step better would be a WARN line that reads

WARN[2023-08-18T12:14:39+01:00] You are running an old version of the Kurtosis CLI. 

Would you like to upgrade the Kurtosis CLI? (Y/N):

@mieubrisse
Copy link
Collaborator

mieubrisse commented Aug 21, 2023

@leeederek Derek agreed, and this message has bugged me for a little while. Unfortunately, Homebrew isn't the only way users install our CLI. What about this?

WARN[2023-08-18T12:14:39+01:00] You are running an old version of the Kurtosis CLI. To update to the latest (0.81.9), run the following:
     <print specific version information; e.g. `brew update && brew install kurtosis-tech/tap/kurtosis-cli`>
     kurtosis engine restart

@leeederek
Copy link
Contributor Author

Fixed by #1254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants