Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: track enclave size after run has finished #15

Merged
merged 10 commits into from
Feb 17, 2023
Merged

feat: track enclave size after run has finished #15

merged 10 commits into from
Feb 17, 2023

Conversation

h4ck3rk3y
Copy link
Contributor

No description provided.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Feb 15, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 7724f31
Status: ✅  Deploy successful!
Preview URL: https://f64ac2a4.kurtosis-docs.pages.dev
Branch Preview URL: https://gyani-enclave-size.kurtosis-docs.pages.dev

View logs

@h4ck3rk3y h4ck3rk3y marked this pull request as draft February 15, 2023 15:11
Base automatically changed from gyani/backend-arch-os to main February 16, 2023 10:28
@h4ck3rk3y h4ck3rk3y marked this pull request as ready for review February 16, 2023 11:49
@h4ck3rk3y h4ck3rk3y requested a review from gbouv February 16, 2023 13:32
gbouv
gbouv reviewed Feb 16, 2023
View reviewed changes
Copy link
Contributor

@gbouv gbouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we don't pass those 2 clients to them method itself, but rather we store a ref to them in the startosis_executor object. Thoughts?

core/server/api_container/server/api_container_service.go Outdated Show resolved Hide resolved
@h4ck3rk3y h4ck3rk3y requested a review from gbouv February 16, 2023 14:56
@h4ck3rk3y h4ck3rk3y merged commit 80f35c8 into main Feb 17, 2023
@h4ck3rk3y h4ck3rk3y deleted the gyani/enclave-size branch February 17, 2023 12:52
@kurtosisbot kurtosisbot mentioned this pull request Feb 17, 2023
Merged
@github-actions github-actions bot mentioned this pull request Mar 20, 2023
Merged
@kurtosisbot kurtosisbot mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbouv gbouv gbouv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@h4ck3rk3y @gbouv