Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tasks remove containers after they are done #1850

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

h4ck3rk3y
Copy link
Contributor

Description:

Closes #1846

Is this change user facing?

YES

This removes task containers after the task is "done"

@h4ck3rk3y
Copy link
Contributor Author

before/after

image image

@h4ck3rk3y h4ck3rk3y requested review from leoporoli and kurtosisbot and removed request for kurtosisbot November 27, 2023 12:20
@h4ck3rk3y h4ck3rk3y added this pull request to the merge queue Nov 27, 2023
Merged via the queue into main with commit 179c541 Nov 27, 2023
33 checks passed
@h4ck3rk3y h4ck3rk3y deleted the gyani/remove-done-tasks branch November 27, 2023 15:06
github-merge-queue bot pushed a commit that referenced this pull request Nov 27, 2023
🤖 I have created a release *beep* *boop*
---


##
[0.85.36](0.85.35...0.85.36)
(2023-11-27)


### Features

* emui enhancements
([#1847](#1847))
([633ba42](633ba42))


### Bug Fixes

* make run_python not create additional files artifact
([#1851](#1851))
([82d0058](82d0058))
* only print image banner if image arch is non empty string and
different
([#1854](#1854))
([75b8c84](75b8c84))
* tasks remove containers after they are done
([#1850](#1850))
([179c541](179c541))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Task containers are left running after the task completes
2 participants