fix: cache bug #1885
Merged
fix: cache bug #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
December 1, 2023 16:53
tedim52
approved these changes
Dec 1, 2023
github-merge-queue bot
pushed a commit
that referenced
this pull request
Dec 2, 2023
🤖 I have created a release *beep* *boop* --- ## [0.85.40](0.85.39...0.85.40) (2023-12-02) ### Features * change change license to Apache 2.0 ([#1884](#1884)) ([64084d8](64084d8)) ### Bug Fixes * cache bug ([#1885](#1885)) ([82e46e2](82e46e2)) * change tail package ([#1874](#1874)) ([f4e87ec](f4e87ec)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
When I introduced the cache I didn't recognize that once the primary user logs in it caches the instance config for any other user to re-use. With this we are scoping the api key and instance config to the jwt token and removing failed login attempts.
Is this change user facing?
YES
References (if applicable):