feat: Engine K8S ingress for REST API reverse proxy routing #1970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurentluce
commented
Dec 17, 2023
...ngine-lib/lib/backend_impls/docker/docker_kurtosis_backend/engine_functions/create_engine.go
Show resolved
Hide resolved
laurentluce
commented
Dec 17, 2023
container-engine-lib/lib/backend_impls/kubernetes/kubernetes_kurtosis_backend/consts/consts.go
Show resolved
Hide resolved
lostbean
approved these changes
Dec 21, 2023
...b/lib/backend_impls/kubernetes/kubernetes_kurtosis_backend/engine_functions/create_engine.go
Show resolved
Hide resolved
...b/lib/backend_impls/kubernetes/kubernetes_kurtosis_backend/engine_functions/create_engine.go
Show resolved
Hide resolved
...b/lib/backend_impls/kubernetes/kubernetes_kurtosis_backend/engine_functions/create_engine.go
Show resolved
Hide resolved
.../lib/backend_impls/kubernetes/kubernetes_kurtosis_backend/engine_functions/shared_helpers.go
Outdated
Show resolved
Hide resolved
Thanks @lostbean for the review! |
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 3, 2024
🤖 I have created a release *beep* *boop* --- ## [0.85.55](0.85.54...0.85.55) (2024-01-03) ### Features * Engine K8S ingress for REST API reverse proxy routing ([#1970](#1970)) ([4287f88](4287f88)) * match emui catalog to final designs ([#2012](#2012)) ([c55fc7a](c55fc7a)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 8, 2024
…#2019) ## Description: Create engine Traefik Docker labels for the REST API port so we can interact with the API via Traefik. The Host header is set to "engine". Tested with Docker locally: ``` $ curl -i http://localhost:9730/api/engine/info -H "Host: engine" HTTP/1.1 200 OK ... {"engine_version":"70d65c"} ``` ## Is this change user facing? NO ## References (if applicable): #1970
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Create engine K8S ingress for the REST API port so we can interact with the API via Traefik. The
Hostheader is set toengine.Tested with k3d locally:
Is this change user facing?
NO
References (if applicable):
#1941