feat: Kurtosis backend can now connect to a remote Docker backend #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbouv
force-pushed
the
gbouv/remote-context-connection
branch
from
45fb086
to
595d0bc
Compare
Deploying with
|
| Latest commit: |
57fafde
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://974167e9.kurtosis-docs.pages.dev |
| Branch Preview URL: | https://gbouv-remote-context-connect.kurtosis-docs.pages.dev |
gbouv
force-pushed
the
gbouv/remote-context-connection
branch
2 times, most recently
from
c6d62d5
to
ace3a91
Compare
gbouv
force-pushed
the
gbouv/remote-context-connection
branch
from
ace3a91
to
1917eca
Compare
h4ck3rk3y
reviewed
Mar 22, 2023
container-engine-lib/lib/backend_impls/remote_context_backend/backend_creator.go
Show resolved
Hide resolved
container-engine-lib/lib/backend_impls/remote_context_backend/backend_creator.go
Outdated
Show resolved
Hide resolved
container-engine-lib/lib/backend_impls/remote_context_backend/backend_creator.go
Show resolved
Hide resolved
container-engine-lib/lib/backend_impls/remote_context_backend/backend_creator.go
Outdated
Show resolved
Hide resolved
h4ck3rk3y
approved these changes
Mar 22, 2023
leoporoli
pushed a commit
that referenced
this pull request
Mar 22, 2023
🤖 I have created a release *beep* *boop* --- ## [0.70.0](0.69.2...0.70.0) (2023-03-22) ### ⚠ BREAKING CHANGES * This is a breaking change where we are removing the ExecRecipe.service_name, GetHttpRequestRecipe.service_name, and PostHttpRequestRecipe.service_name fields, we suggest users pass this value as an argument in the exec, request and wait instructions where this type is currently used. We are also deprecating the previous exec, request, and wait instructions signature that haven't the service_name field, users must add this field on these instructions call. Another change is that now the service_name field on the exec, request, and wait instructions is mandatory ([#301](#301)) ### Features * Kurtosis backend can now connect to a remote Docker backend ([#285](#285)) ([98b04c8](98b04c8)) * This is a breaking change where we are removing the ExecRecipe.service_name, GetHttpRequestRecipe.service_name, and PostHttpRequestRecipe.service_name fields, we suggest users pass this value as an argument in the exec, request and wait instructions where this type is currently used. We are also deprecating the previous exec, request, and wait instructions signature that haven't the service_name field, users must add this field on these instructions call. Another change is that now the service_name field on the exec, request, and wait instructions is mandatory ([#301](#301)) ([eb7e88f](eb7e88f)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: kurtosisbot <kurtosisbot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds a specific type of backend consisting of both the local Docker backend and a remote Kurtosis backend (which is effectively Docker). CLI and Engine are using this specific backend to be able to offload some containers to the remote backend based on the current context config
Is this change user facing?
NO -- since we don't have the possibility to switch backend right now, this is effectively not exposed
References (if applicable):