Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate nature theme based name to cli (render template and store service) for file artifacts #82

Merged
merged 1 commit into from
Mar 3, 2023
Merged

feat: integrate nature theme based name to cli (render template and store service) for file artifacts #82

merged 1 commit into from
Mar 3, 2023

Conversation

Peeeekay
Copy link
Contributor

@Peeeekay Peeeekay commented Mar 1, 2023 •
edited by github-actions bot
Loading

Changelog picked up from commits here:

feat: integrate nature theme named to render_template and store_service

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Mar 1, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 56d8372
Status: ✅  Deploy successful!
Preview URL: https://0430c8f5.kurtosis-docs.pages.dev
Branch Preview URL: https://pk-expose-name-generation-to.kurtosis-docs.pages.dev

View logs

@Peeeekay
Copy link
Contributor Author

Peeeekay commented Mar 1, 2023 •
edited
Loading

I am basically integrating the name themed auto-generation of file-artifacts name to the CLI.

Let me know if you have any questions, but I was stuck between either updating the current response from enclaveCtx methods like UploadFiles etc, because we only return UUIDs ( was reluctant to break the contract for SDK apis) or create new a RPC method which I can call to get a unique nature themed name.

I went with the latter as it I wanted to make this PR backward compatible as this particular feature should not be breaking imo opinion.

@Peeeekay Peeeekay force-pushed the pk/expose_name_generation_to_cli branch 2 times, most recently from 723197e to 7d29216 Compare March 1, 2023 02:18
@Peeeekay Peeeekay requested a review from gbouv March 1, 2023 03:15
gbouv
gbouv reviewed Mar 1, 2023
View reviewed changes
Copy link
Contributor

@gbouv gbouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of that implementation TBH. I don't think we want to expose such a specialized and narrow functionality to our API. What about instead we make the artifactName arg option on our UploadFiles API function, and handle the mechanics of generating a unique one entirely in the backend?

@Peeeekay Peeeekay force-pushed the pk/expose_name_generation_to_cli branch 4 times, most recently from 8cd90fc to 7b370c3 Compare March 2, 2023 03:46
@Peeeekay Peeeekay requested a review from gbouv March 2, 2023 04:40
@Peeeekay Peeeekay changed the title feat: integrate nature theme based name to cli for file artifacts feat: integrate nature theme based name to cli (render template and store service) for file artifacts Mar 2, 2023
@Peeeekay Peeeekay force-pushed the pk/expose_name_generation_to_cli branch from 7b370c3 to 2fe08fb Compare March 2, 2023 06:25
@Peeeekay Peeeekay force-pushed the pk/expose_name_generation_to_cli branch from fdfdebf to 56d8372 Compare March 3, 2023 01:30
@Peeeekay Peeeekay merged commit aea5bef into main Mar 3, 2023
@Peeeekay Peeeekay deleted the pk/expose_name_generation_to_cli branch March 3, 2023 01:41
@kurtosisbot kurtosisbot mentioned this pull request Mar 3, 2023
Merged
@github-actions github-actions bot mentioned this pull request Mar 20, 2023
Merged
@kurtosisbot kurtosisbot mentioned this pull request Mar 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbouv gbouv gbouv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peeeekay @gbouv