-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build CLI binary as executable prior to zip/release #2880
Comments
We're using the upload-artifact action, which according to its documentation does not preserve file permissions (not all zip tools handle permissions, as permissions were an extension of the format as far as I'm aware). There is an open issue. I think all that should be necessary is to manually create the zip archive with a tool that supports permissions, and upload that. |
Instead of creating zip file, let's just switch to
There are also several related issues: actions/upload-artifact#109 and actions/upload-artifact#39. So this means that the build pipeline will create a |
Does this work on all OSes without any issues? If so, we should properly document it. |
tar.gz should be supported by macOS and most Linux distros by default. For Windows, we will keep publishing zip. I do not have a Windows machine to test right now, but I think Windows also does not require setting permission for exe files (@acquamarin and @benjaminwinger can comment)? |
No, windows doesn't have executable permissions. |
The current CLI downloaded via the URL (for example, this one), when unzipped just provides a file. The user has to manually convert the file to an executable on Linux/MacOS by typing
chmod +x kuzu
to allow it to be executed.Is there something that could be done during the build process that allows us to unzip the downloaded file directly as an executable?
The text was updated successfully, but these errors were encountered: