Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make proper releases including the generated artifacts #59

Closed
kylegoetz opened this issue Apr 12, 2024 · 7 comments
Closed

make proper releases including the generated artifacts #59

kylegoetz opened this issue Apr 12, 2024 · 7 comments
Assignees

Comments

@kylegoetz
Copy link
Owner

kylegoetz commented Apr 12, 2024

splitting this into its own issue but originally brought up by @clason in #56

consider making proper releases including the generated artifacts (which is what nvim-treesitter will require for "stable" parsers). Upstream is in the process of adding reusable workflows and tree-sitter support to make this easier.

https://github.com/tree-sitter/workflows

@kylegoetz kylegoetz self-assigned this Apr 12, 2024
@kylegoetz kylegoetz changed the title consider making proper releases including the generated artifacts make proper releases including the generated artifacts Apr 12, 2024
@kylegoetz
Copy link
Owner Author

latest in test process https://github.com/kylegoetz/tree-sitter-unison/actions/runs/8665499830/job/23764328299#step:4:436

undef references to tree_sitter_unison_external_scanner_deserialize and its ilk. These are confirmed present in src/scanner.c

@kylegoetz
Copy link
Owner Author

Working on this now. The npm-publish workflow provided by Tree Sitter errors out with an illegal cast (or, rather, a failed assert based on a problematic cast) in Node's own source code. Looking to see what might be the issue.

@kylegoetz
Copy link
Owner Author

Windows build fails, output is confusing. Looks like the build process invokes prebuildify with invalid arguments?

@ObserverOfTime
Copy link

You need to run tree-sitter generate to update the bindings.
Then manually fix the missing scanner and incorrect metadata.

@kylegoetz
Copy link
Owner Author

kylegoetz commented Apr 15, 2024

@ObserverOfTime turns out prebuildify has a bug with a PR waiting to fix it

prebuild/prebuildify#84

I've already re-generated and manually fixd the missing scanner. Prebuildify on Windows appears to fail specifically because of this issue: prebuild/prebuildify#83 so I'm just waiting for the PR to be accepted and then nopefully the NPM deployment workflow will work again. It seems this is an issue with Windows Node 20 where they forbid the use of files with a certain file extension unless shell: true is set in the opts, and it's currently not

@kylegoetz
Copy link
Owner Author

Screen Shot 2024-04-15 at 12 03 11 PM

@kylegoetz
Copy link
Owner Author

finished and 1.1.2 built and uploaded to NPM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants