Encryption update, linting fixes

Author: kyleu

.golangci.yml

@@ -166,7 +166,7 @@ linters:
     # - structcheck # deprecated
     - stylecheck
     # - tagliatelle
-    - tenv
+    # - tenv
     - testpackage
     - thelper
     - tparallel
@@ -175,6 +175,7 @@ linters:
     # - unparam
     - unused
     - usestdlibvars
+    - usetesting
     # - varcheck # deprecated
     # - varnamelen
     - wastedassign

app/lib/filter/params.go

@@ -166,11 +166,9 @@ func (p *Params) Filtered(key string, available []string, logger util.Logger) *P
 			})
 			if containsCol {
 				allowed = append(allowed, o)
-			} else {
-				if logger != nil {
-					const msg = "no column [%s] for [%s] available in allowed columns [%s]"
-					logger.Warnf(msg, o.Column, p.Key, util.StringArrayOxfordComma(available, "and"))
-				}
+			} else if logger != nil {
+				const msg = "no column [%s] for [%s] available in allowed columns [%s]"
+				logger.Warnf(msg, o.Column, p.Key, util.StringArrayOxfordComma(available, "and"))
 			}
 		})
 		return &Params{Key: p.Key, Orderings: allowed, Limit: p.Limit, Offset: p.Offset}

app/util/encryption.go

@@ -32,7 +32,7 @@ func EncryptMessage(key []byte, message string, logger Logger) (string, error) {
 		return "", errors.Wrap(err, "could not encrypt")
 	}
 
-	stream := cipher.NewCFBEncrypter(block, iv)
+	stream := cipher.NewCTR(block, iv)
 	stream.XORKeyStream(cipherText[aes.BlockSize:], byteMsg)
 
 	return base64.StdEncoding.EncodeToString(cipherText), nil
@@ -55,7 +55,7 @@ func DecryptMessage(key []byte, message string, logger Logger) (string, error) {
 	iv := cipherText[:aes.BlockSize]
 	cipherText = cipherText[aes.BlockSize:]
 
-	stream := cipher.NewCFBDecrypter(block, iv)
+	stream := cipher.NewCTR(block, iv)
 	stream.XORKeyStream(cipherText, cipherText)
 
 	return string(cipherText), nil

app/util/random.go

@@ -9,6 +9,7 @@ import (
 	"time"
 
 	"github.com/samber/lo"
+	"github.com/samber/lo/mutable"
 )
 
 const charset = "abcdefghijklmnopqrstuvwxyz0123456789"
@@ -93,7 +94,10 @@ func RandomURL() *url.URL {
 
 func RandomElements[T any](slice []T, idx int) []T {
 	if len(slice) <= idx {
-		return lo.Shuffle(slice)
+		x := make([]T, len(slice))
+		copy(slice, x)
+		mutable.Shuffle(x)
+		return x
 	}
 	return lo.Map(lo.Range(idx), func(_ int, _ int) T {
 		return slice[RandomInt(len(slice))]