Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RateLimit CRD #1467

Open
15 tasks
Tracked by #1365
strekm opened this issue Nov 20, 2024 · 0 comments
Open
15 tasks
Tracked by #1365

RateLimit CRD #1467

strekm opened this issue Nov 20, 2024 · 0 comments
Assignees
@kolodziejczak
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Milestone
2.11.0

Comments

@strekm
Copy link
Contributor

strekm commented Nov 20, 2024

Description

Introduce RateLimit CRD as described in accepted ADR. Implement in code and CRD validation. Creation of corresponding EnvoyFilter is out of scope of this task. New CRD should be hidden behind rate limiting feature toggle and should not be user facing.

Reasons

Contact

ToDos [Developer]

  • generate CRD
  • implement reconcile function
  • implement CRD validation
  • implement in code validation if needed

PRs

ACs [PO]

  • RateLimit CRD introduced with validation
  • EnvoyFilter CR is not created
  • the CRD is hidden behind FT

DoD [Developer & Reviewer]

  • Provide unit and integration tests.
  • Provide documentation.
  • Verify if the solution works for both open-source Kyma and SAP BTP, Kyma runtime.
  • If you changed the resource limits, explain why it was needed.
  • If the default configuration of Istio Operator has been changed, you performed a manual upgrade test to verify that the change can be rolled out correctly.
  • Verify that your contributions don't decrease code coverage. If they do, explain why this is the case.
  • Add release notes.

Attachments
part of: #1365

Follow-Up Issues
@strekm strekm added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 20, 2024
@strekm strekm added this to the 2.11.0 milestone Nov 20, 2024
@strekm strekm mentioned this issue Nov 22, 2024
Open
12 tasks
@kolodziejczak kolodziejczak self-assigned this Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kolodziejczak kolodziejczak

Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
2.11.0
Development

No branches or pull requests
2 participants
@strekm @kolodziejczak