-
Notifications
You must be signed in to change notification settings - Fork 405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace "registry" pkg with AdmissionWebhooks in SC #2792
Comments
For validation take into account that we have already the static validation on CRD, so recheck what else needs to be done in ValidatingAdmissionWebhook. Check also if we shouldn't remove the static validation from CRD and implement that in ValidatingAdmissionWebhook - take into account how user-friendly is the returned validation error. |
Remember about DoD:
|
All resources status update does executes validation.validateStatus* methods, but such methods does not performs any checks on status except ServiceBinding |
Description
Storage for api-server is placed in
registry
pkg. There we can find functions which are used to prepare for CREATE/UPDATE (mutators) and also some validatorsWe should be able to reuse most of the code but we will need to adjust it to fulfill webhook API.
Assumptions:
SC
Blocked by: #2784
The text was updated successfully, but these errors were encountered: