Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace "registry" pkg with AdmissionWebhooks in SC #2792

Closed
adamwalach opened this issue Feb 19, 2019 · 3 comments · Fixed by kyma-incubator/service-catalog#17
Closed

Replace "registry" pkg with AdmissionWebhooks in SC #2792

adamwalach opened this issue Feb 19, 2019 · 3 comments · Fixed by kyma-incubator/service-catalog#17
Assignees
Labels
area/service-management Issues or PRs related to service management

Comments

@adamwalach
Copy link
Contributor

adamwalach commented Feb 19, 2019

Description

Storage for api-server is placed in registry pkg. There we can find functions which are used to prepare for CREATE/UPDATE (mutators) and also some validators

We should be able to reuse most of the code but we will need to adjust it to fulfill webhook API.

Assumptions:

  • K8s at least in version 1.9

SC

Blocked by: #2784

@adamwalach adamwalach added the area/service-management Issues or PRs related to service management label Feb 19, 2019
@mszostok mszostok added this to the Sprint_Gopher_12 milestone Feb 22, 2019
@PK85 PK85 modified the milestones: Sprint_Gopher_12, Sprint_Gopher_13 Mar 4, 2019
@mszostok
Copy link
Contributor

mszostok commented Mar 7, 2019

For validation take into account that we have already the static validation on CRD, so recheck what else needs to be done in ValidatingAdmissionWebhook.

Check also if we shouldn't remove the static validation from CRD and implement that in ValidatingAdmissionWebhook - take into account how user-friendly is the returned validation error.

@mszostok
Copy link
Contributor

Remember about DoD:

  • execute make verify and it MUST end without error
  • execute make test-unit and it MUST end without error
  • execute make format
  • check if your changes need to be applied also for svcat. If yes then modify it and then test it also manually. HINT: Create a binary:
    make svcat
    
    generated binary will be placed in bin/svcat/svcat
  • finally, always generate a new image and update tag in chart
  • finally, test service catalog by installing chart and walkthrough happy path flow both for namespace-scope and cluster-wide brokers. Happy path means creating and deleting all objects.

@piotrmiskiewicz piotrmiskiewicz self-assigned this Mar 22, 2019
@PK85 PK85 modified the milestones: Sprint_Gopher_13, Sprint_Gopher_14 Mar 25, 2019
@piotrmiskiewicz
Copy link
Member

All resources status update does executes validation.validateStatus* methods, but such methods does not performs any checks on status except ServiceBinding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-management Issues or PRs related to service management
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants