You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Remove ModuleTemplate Webhook
With the updated pattern of offering ModuleTemplate, we no longer need to validate it through a webhook. This allows us to fully remove moduletemplate_webhook.go:
Relocate Descriptor Struct
The Descriptor struct, which currently relies on the ocm library, is declared in the API module. We can move it to the lifecycle-manager module, eliminating the need for ocm in the API module:
Reduce API Module Dependencies: Simplifies maintenance for other modules relying on the API, like runtime-watcher.
Improve KLM Performance: Removing the webhook increases performance and removes a potential single point of failure from the embedded webhook service.
Acceptance Criteria
Remove ModuleTemplate Webhook
Relocate Descriptor Struct
Adjust the Management Plane Charts repository (values.yaml, validating-webhooks.yaml files)
Check whether the webhook was dropped after the release
The change should be introduced in 2 steps:
Disable the webhook in configuration and release/promote to the landscapes
Drop the code from KLM + release new version
The text was updated successfully, but these errors were encountered:
ruanxin
changed the title
Drop moduletemplate webhook and decouple ocm from api module
[Module Catalog] Drop moduletemplate webhook and decouple ocm from api module
Nov 12, 2024
Remove ModuleTemplate Webhook
With the updated pattern of offering ModuleTemplate, we no longer need to validate it through a webhook. This allows us to fully remove moduletemplate_webhook.go:
lifecycle-manager/api/v1beta2/moduletemplate_webhook.go
Line 37 in 8097721
Relocate
Descriptor
StructThe Descriptor struct, which currently relies on the ocm library, is declared in the API module. We can move it to the lifecycle-manager module, eliminating the need for ocm in the API module:
lifecycle-manager/api/v1beta2/moduletemplate_types.go
Line 52 in 8097721
Reasons
Acceptance Criteria
Descriptor
StructThe change should be introduced in 2 steps:
The text was updated successfully, but these errors were encountered: