Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Module Catalog] Drop moduletemplate webhook and decouple ocm from api module #2006

Open
4 tasks
ruanxin opened this issue Nov 4, 2024 · 1 comment · May be fixed by #2041
Open
4 tasks

[Module Catalog] Drop moduletemplate webhook and decouple ocm from api module #2006

ruanxin opened this issue Nov 4, 2024 · 1 comment · May be fixed by #2041
Assignees

Comments

@ruanxin
Copy link
Contributor

ruanxin commented Nov 4, 2024

  • Remove ModuleTemplate Webhook
    With the updated pattern of offering ModuleTemplate, we no longer need to validate it through a webhook. This allows us to fully remove moduletemplate_webhook.go:

    func (m *ModuleTemplate) SetupWebhookWithManager(mgr ctrl.Manager) error {

  • Relocate Descriptor Struct
    The Descriptor struct, which currently relies on the ocm library, is declared in the API module. We can move it to the lifecycle-manager module, eliminating the need for ocm in the API module:

    *compdesc.ComponentDescriptor

Reasons

  • Reduce API Module Dependencies: Simplifies maintenance for other modules relying on the API, like runtime-watcher.
  • Improve KLM Performance: Removing the webhook increases performance and removes a potential single point of failure from the embedded webhook service.

Acceptance Criteria

  • Remove ModuleTemplate Webhook
  • Relocate Descriptor Struct
  • Adjust the Management Plane Charts repository (values.yaml, validating-webhooks.yaml files)
  • Check whether the webhook was dropped after the release

The change should be introduced in 2 steps:

  1. Disable the webhook in configuration and release/promote to the landscapes
  2. Drop the code from KLM + release new version
@ruanxin ruanxin changed the title Drop moduletemplate webhook and decouple ocm from api module [Module Catalog] Drop moduletemplate webhook and decouple ocm from api module Nov 12, 2024
@ruanxin
Copy link
Contributor Author

ruanxin commented Nov 15, 2024

@lindnerby lindnerby self-assigned this Nov 19, 2024
@lindnerby lindnerby linked a pull request Nov 21, 2024 that will close this issue
@lindnerby lindnerby linked a pull request Nov 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants