Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the fallback to use generation in ComponentDescriptorCache key #995

Open
2 tasks
nesmabadr opened this issue Oct 31, 2023 · 3 comments
Open
2 tasks
Labels
area/quality Related to all activites around quality good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@nesmabadr
Copy link
Contributor

nesmabadr commented Oct 31, 2023

Description

Currently we use the module version from the annotation added in the ModuleTemplate as part of the ComponentDescriptorCache key. If the annotation is not found we fall back to using the generation instead. After all ModuleTemplates have the module version in them, we need to remove this fallback logic.
This is a followup item for #929

ACs:

@janmedrek janmedrek added area/quality Related to all activites around quality kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Dec 15, 2023
@janmedrek
Copy link
Contributor

Version should be added as a specific field in the ModuleTemplate, until then it is blocked.

@janmedrek
Copy link
Contributor

Related to versions in the Module Catalogue: #1472

@c-pius c-pius added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label Nov 19, 2024
@c-pius
Copy link
Contributor

c-pius commented Dec 4, 2024

Do we need to block this until once all ModuleTemplates have the module version assigned in the CR is true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/quality Related to all activites around quality good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

No branches or pull requests

3 participants