Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image syncer support for multiple external-images.yaml files #11184

Closed
3 tasks
dekiel opened this issue Jul 1, 2024 · 1 comment
Closed
3 tasks

Image syncer support for multiple external-images.yaml files #11184

dekiel opened this issue Jul 1, 2024 · 1 comment
Labels
area/automation Issues or PRs related to automation. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dekiel
Copy link
Contributor

dekiel commented Jul 1, 2024

The image syncer tool should support multiple files with definition which images to sync. At present the tool is reading this data from one file external-images.yaml. Because the file is shared between all teams, a neighbors team is a codeowner of the file. We review and accept changes in the file even when the change doesn't relate to our work. Having support for multiple files, each team could have it's own file and maintain it's content. This way Neighbors team will not review changes which are not related to our work and we don't have required knowledge about the change. Additionally having CODEOWNERS entries for each file, it will be documented which team owns synced images.

We might consider adding support for external-imges.yaml files hosted in other teams repositories. This would be even more convienient for the teams. The problem might be to work with duplicated images to sync.

ACCEPTANCE CRITERIA

  • Image syncer support multiple external-images.yaml files.
  • CODEOWNERS file has entry for each file.
  • Files are stored under repository global /configs directory.
@dekiel dekiel added kind/feature Categorizes issue or PR as related to a new feature. area/automation Issues or PRs related to automation. labels Jul 1, 2024
@Sawthis
Copy link
Contributor

Sawthis commented Aug 20, 2024

duplicate of #11384

@Sawthis Sawthis closed this as completed Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/automation Issues or PRs related to automation. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

2 participants