Image syncer amd64Only flag doesn’t prevent syncing image index

[Sawthis]

Description

An amd64Only flag doesn’t prevent syncing image index and most probably single images for other architecture.
Example, node image identified by digest is in fact an image index, as such was synced with our registry.

test-infra/cmd/image-syncer/external-images.yaml

Lines 119 to 121 in 73a7e66

	- source: "node@sha256:a3816e038e05ea70d2640c845c285f49e416bdae2481a7ff94fde96647a10607"
	tag: "22.3.0"
	amd64Only: true

https://console.cloud.google.com/artifacts/docker/kyma-project/europe/prod/external%2Flib[…]b=manifest?project=kyma-project&supportedpurview=project
In reality, this flag enables allowing syncing an image manifest if it’s defined as source. There is no checks about architecture.

I believe this flag suppose to implement:

Goal is to extend the current image cloner to support also Mac M1 architectures (please make it configurable which archs it has to support).

From #6388

Possible solution:

• We can change a flag name to indicate what it does in reality.
• Change the tool to really sync only amd64.
• Delete the flag as it doesn't do what it should.

Acceptance Criteria

• Delete the flag as it doesn't do what it should.
• It should possible to sync index with multi-platform images.

Attachments

#11916

[Sawthis]

@dekiel I think we should change the flag name to something like: allowSyncImageManifest.

[Sawthis]

Decision from Kyma PO meeting: Flag can be deleted / changed.

CC: @dekiel