Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing scrollbar on the side when page is on full screen #35

Open
linarietuma opened this issue Mar 16, 2021 · 1 comment · May be fixed by #110
Open

Removing scrollbar on the side when page is on full screen #35

linarietuma opened this issue Mar 16, 2021 · 1 comment · May be fixed by #110
Labels
dev/frontend Something related to client-side development priority/medium To be done in a reasonable time

Comments

@linarietuma
Copy link
Collaborator

linarietuma commented Mar 16, 2021

To show that we've implemented the requirement of a single-page view for the application could just include overflow: hidden in the body of the page which removes the scrollbar (given that we're demoing the page on large enough screen to fit everything), the downside is that it then applies to a resized page as well which is not ideal.

@linarietuma linarietuma added priority/medium To be done in a reasonable time dev/frontend Something related to client-side development labels Mar 16, 2021
@kymckay
Copy link
Owner

kymckay commented Mar 16, 2021

This is an interesting point. The scrollbar doesn't actually make it non-single page, but I think perhaps we should take the opposite approach and update our specifications with one to specify a screen size we're targeting for a non-scrolling design (since we cannot guarantee it for every device)

@jonleesy jonleesy linked a pull request Mar 24, 2021 that will close this issue
@kymckay kymckay closed this as completed Mar 24, 2021
@kymckay kymckay reopened this Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/frontend Something related to client-side development priority/medium To be done in a reasonable time
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants