Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Persist additional options / flags in the config on --install #150

Open
casperdcl opened this issue Apr 23, 2021 · 1 comment
Open

Persist additional options / flags in the config on --install #150

casperdcl opened this issue Apr 23, 2021 · 1 comment
Labels
help wanted type:enhancement
Milestone
Backlog

Comments

@casperdcl
Copy link
Contributor

casperdcl commented Apr 23, 2021 •
edited
Loading

e.g. nbstripout --install --keep-count should put the --keep-count flag in the resultant git config filter.nbstripout.clean and git config diff.ipynb.textconv commands.

This applies to:

  • --keep-count
  • --keep-output
@casperdcl casperdcl changed the title --install with other options --install with other (--keep-*) options Apr 23, 2021
@casperdcl casperdcl changed the title --install with other (--keep-*) options --install with other (--keep-*) options Apr 23, 2021
@kynan kynan added this to the Backlog milestone Apr 24, 2021
@kynan
Copy link
Owner

kynan commented Sep 24, 2022

Great suggestion :) Feel like sending a PR for this @casperdcl ?

@igor-sb igor-sb mentioned this issue Jan 25, 2024
Closed
@kynan kynan changed the title --install with other (--keep-*) options Persist additional options / flags in the config on --install Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type:enhancement
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@kynan @casperdcl