Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nbstripout version 0.3.3 version doesn't work #93

Closed
AbhimanyuAryan opened this issue Feb 21, 2019 · 5 comments
Closed

nbstripout version 0.3.3 version doesn't work #93

AbhimanyuAryan opened this issue Feb 21, 2019 · 5 comments

Comments

@AbhimanyuAryan
Copy link

AbhimanyuAryan commented Feb 21, 2019

I have saved changed in my nb & then I ran nbstripout --install in my git repo. It still picks some random changes

I only added two changes in notebook. file-type mime-type all of these additions are useless. How can I strip them?

@@ -57,7 +57,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "a = tensor(3.,2); a"
+    "a = torch.tensor([3.,2]); a"
    ]
   },
   {
@@ -107,7 +107,7 @@
    "metadata": {},
    "outputs": [],
    "source": [
-    "a = tensor(-1.,1)"
+    "a = torch.tensor([-1.,1])"
    ]
   },
   {
@@ -280,8 +280,20 @@
    "display_name": "Python 3",
    "language": "python",
    "name": "python3"
+  },
+  "language_info": {
+   "codemirror_mode": {
+    "name": "ipython",
+    "version": 3
+   },
+   "file_extension": ".py",
+   "mimetype": "text/x-python",
+   "name": "python",
+   "nbconvert_exporter": "python",
+   "pygments_lexer": "ipython3",
+   "version": "3.6.1"
   }
  },
  "nbformat": 4,
- "nbformat_minor": 1
+ "nbformat_minor": 2
@kynan
Copy link
Owner

kynan commented Mar 26, 2019

This is currently being addressed in #92.

@kynan kynan added state:waiting Waiting for response for reporter type:bug labels Mar 26, 2019
@kynan
Copy link
Owner

kynan commented Mar 26, 2019

I've just released 0.3.4, please give it a try.

@AbhimanyuAryan
Copy link
Author

AbhimanyuAryan commented Mar 27, 2019

sure. I'll update you after try :)

@kynan kynan added this to the 0.3.4 milestone Apr 2, 2019
@kynan
Copy link
Owner

kynan commented Jun 30, 2019

@AbhimanyuAryan Friendly ping, can this be closed?

@AbhimanyuAryan
Copy link
Author

AbhimanyuAryan commented Jul 10, 2019

@kynan I might not be able to test it right now. If it's fixed at your end. Feel free to close it. I'll report again if I face this issue or continue on #92

@kynan kynan closed this as completed Jul 14, 2019
@kynan kynan added resolution:fixed and removed state:waiting Waiting for response for reporter labels Aug 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants